Skip to content

Fix/anat fast track derivative#35

Open
htwangtw wants to merge 4 commits intomainfrom
fix/anat-fast-track-derivative
Open

Fix/anat fast track derivative#35
htwangtw wants to merge 4 commits intomainfrom
fix/anat-fast-track-derivative

Conversation

@htwangtw
Copy link
Collaborator

@htwangtw htwangtw commented Apr 2, 2024

Closes #32
Closes #33
Closes #34

Solution: ignore anatomical metrics if anat/ is not present

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 10.85%. Comparing base (c7b951f) to head (adf5437).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
- Coverage   94.46%   10.85%   -83.62%     
===========================================
  Files           5        8        +3     
  Lines         235      350      +115     
===========================================
- Hits          222       38      -184     
- Misses         13      312      +299     
Files Coverage Δ
giga_auto_qc/workflow.py 8.10% <0.00%> (-77.61%) ⬇️
giga_auto_qc/tests/test_assessments.py 7.27% <0.00%> (ø)
giga_auto_qc/assessments.py 5.33% <0.00%> (-90.45%) ⬇️

... and 4 files with indirect coverage changes

@htwangtw htwangtw requested review from bpinsard and clarkenj April 3, 2024 16:18
@htwangtw
Copy link
Collaborator Author

@clarkenj On compute canada you can pull the build of this PR to test it out
apptainer build giga_auto_qc_unstable.simg docker://haotingwang/giga_auto_qc:unstable

@htwangtw
Copy link
Collaborator Author

htwangtw commented Apr 11, 2024

Request from @clarkenj to be addressed: when supplying anatomical only directory, calculate the anatomical dice
Not addressing this as it turned out to be more complicated than I thought.

* ignore unwanted identifier parts

* remove print statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add total frames to qc output ImportError due to nilearn API change (nilearn>=0.10.3) error on fmriprep output with anatomical fast-track

3 participants