RTPStream: Streamline RTPEcho debug logs #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There's no way in github to properly review dependent changes, so this PR includes #848. I'll rebase it once the other one is merged (or you can try to review only the last commit). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| std::lock_guard lock(mutex); | ||
| va_list args; | ||
| va_start(args, format); | ||
| // fprintf(fp, "TID: %lu ", tid_self()); |
Check notice
Code scanning / CodeQL
Commented-out code Note
lemenkov
approved these changes
Feb 1, 2026
Member
lemenkov
left a comment
lemenkov
left a comment
There was a problem hiding this comment.
LGTM. Consider removing commented out code.
Contributor
Author
I'd consider uncommenting it, but that could break the expected output for existing users, so I'm reluctant about it. What do you think? |
Member
|
Feel free to keep it as is - anyway that's a cosmetic thing. Let's switch to more interesting things and put less important tasks aside for a while :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.