Modernize timing functions with C++11 std::chrono #854
+27
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sipp_usleep() function was a workaround for POSIX usleep() having undefined behavior for values >= 1,000,000 microseconds. However: - usleep() was deprecated in POSIX.1-2001 and removed in POSIX.1-2008 - C++11 std::this_thread::sleep_for() handles arbitrary durations correctly - The function was only used in 3 places, none requiring microsecond precision Replace with direct std::this_thread::sleep_for() calls using appropriate std::chrono duration types. Signed-off-by: Peter Lemenkov <[email protected]> Assisted-by: Claude (Anthropic) <https://claude.ai>
Signed-off-by: Peter Lemenkov <[email protected]>
Use std::chrono::steady_clock instead of clock_gettime() with platform-specific workarounds. This removes: - Obsolete macOS Mach clock workaround (clock_gettime available since 10.12) - CLOCK_MONOTONIC_COARSE optimization (negligible performance impact) - Legacy includes: time.h, sys/time.h, unistd.h, mach/clock.h, mach/mach.h Signed-off-by: Peter Lemenkov <[email protected]> Assisted-by: Claude (Anthropic) <https://claude.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace legacy POSIX timing APIs with modern C++11 equivalents.