REST addon: allow users to implement custom additional routes#1945
Draft
ludolpif wants to merge 6 commits intoSanderMertens:masterfrom
Draft
REST addon: allow users to implement custom additional routes#1945ludolpif wants to merge 6 commits intoSanderMertens:masterfrom
ludolpif wants to merge 6 commits intoSanderMertens:masterfrom
Conversation
…t force default API routes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As briefly discussed on FLECS discord, I choosen AGPL on my current fun project (LLSS, a mockup of a OBS-like streaming software, based on game-oriented libraries) and, as it is in early development stages, I want to:
This leads me to try to add a route like "/sources" in the REST API, keeping the others intact. It seems this needs to make a few
rest.cfunctions public, at least:flecs_rest_reply()butflecs_reply_error()andflecs_rest_server_garbage_collect()seems to be very useful also.Here is my first draft of this. What is done:
flecs_rest_reply()public and don't forceprivate_desc.callback = flecs_rest_reply;inflecs_rest_reply()example/c/restIf you still think it could be fine to go for it, could you provide some feedback on this to show me a good way to improve it ?
Thanks,