query: use actual table id for IsA matches in fixed traversal#2035
Open
60k41p wants to merge 4 commits intoSanderMertens:masterfrom
Open
query: use actual table id for IsA matches in fixed traversal#203560k41p wants to merge 4 commits intoSanderMertens:masterfrom
60k41p wants to merge 4 commits intoSanderMertens:masterfrom
Conversation
Updates `flecs_query_trav_fixed_src_up_fixed_second` to use the actual component ID stored in the table's type array when a match is found for an `EcsIsA` relationship, rather than reconstructing the pair from arguments. Changes: - Capture the column index returned by `ecs_search_relation`. - Add a check for `column != -1` to ensure the relationship was found in the table (Self) before accessing the type array. - When `trav == EcsIsA`, set the matched ID to `table->type.array[column]`. - Manually populate the iterator fields and variables with the resolved `matched` ID. This ensures that the query iterator reports the exact component ID present in the archetype when matching `IsA` relationships.
Owner
|
Can you add a test case that reproduces the failure that this fixes? |
Contributor
Author
Test added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
flecs_query_trav_fixed_src_up_fixed_secondto use the actual component ID stored in the table's type array when a match is found for anEcsIsArelationship, rather than reconstructing the pair from arguments.Bug repro
Changes:
ecs_search_relation.index != -1to ensure the relationship was found in the table (Self) before accessing the type array.trav == EcsIsA, set the matched ID totable->type.array[column].matchedID.This ensures that the query iterator reports the exact component ID present in the archetype when matching
IsArelationships.Also, this PR updates the link to the Stagehand repository (which got renamed from VoxInteractive/Godot-Flecs).