Skip to content

Fix direct-function interval tests#1083

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/fix-direct-function-domainsets-interval
Jul 9, 2026
Merged

Fix direct-function interval tests#1083
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/fix-direct-function-domainsets-interval

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

This PR should be ignored until reviewed by @ChrisRackauckas.

Summary

  • import DomainSets.Interval in the direct-function tests
  • replace removed/undefined IntervalDomain usage with Interval

Local verification

timeout 3600 /home/crackauc/.juliaup/bin/julia +1.12 --project=. -e 'import Pkg; Pkg.instantiate(); include("test/direct_function__empty_boundary_condition_fails_in_solve_phase.jl"); include("test/direct_function__trivial_bc_0_0_fails_for_some_training_strategies.jl")'\n\nTest Summary:                                    | Pass  Total     Time\nEmpty boundary condition [] fails in solve phase |    4      4  2m00.8s\nTest Summary:                                         | Pass  Total  Time\nTrivial BC [0 ~ 0] fails for some training strategies |    2      2  1.2s\n```\n\nAlso ran `git diff --check`, with no output.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 9, 2026 12:50
@ChrisRackauckas
ChrisRackauckas merged commit bfcbae6 into SciML:master Jul 9, 2026
28 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants