Update bad Broyden robustness expectations#1069
Draft
ChrisRackauckas-Claude wants to merge 2 commits into
Draft
Conversation
Bad Broyden with true-Jacobian resets is not numerically robust on the generalized Rosenbrock start, while the Brown almost-linear case now reaches the residual tolerance. Track that solver behavior in the 23-problem expectations instead of restoring dense pinv semantics globally. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This was referenced Jul 15, 2026
The Julia 1 macOS Core job shows bad Broyden with true-Jacobian resets still misses the Brown almost-linear residual tolerance on Apple while Linux passes it. Keep the expected failure platform-scoped so the Linux path remains checked. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Author
|
The underlying generalized-Rosenbrock failure is a clean- Adding this case to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Summary
1.0000050490184778pinvfallback semantics globally just to satisfy fragile method/problem pairsRationale
Bad Broyden is numerically unstable on these hard robustness cases, so the test should reflect the solver contract instead of forcing the old dense inverse-initialization behavior. This is the narrower alternative to #1058.
Validation
origin/masterfocused run reproduced the generalized Rosenbrock alg Make iip a compile-time constant #4 failure:4.3999999999999995 <= 0.001was false.Unstablewith residual4.3999999999999995, problems 5/6/11 remain failures/errors, and problem 8 reaches residual7.314149286230531e-13.1.0000050490184778, so problem 8 is expected-broken only underSys.isapple().env JULIA_NUM_THREADS=1 JULIA_PKG_PRECOMPILE_AUTO=no JULIA_PKG_SERVER_REGISTRY_PREFERENCE=eager timeout 3600 /home/crackauc/.juliaup/bin/julia +1 --startup-file=no --project=/home/crackauc/sandbox/tmp_20260708_121627_10236/nls_broyden_known_case_env -e 'using Test; include("test/Core/23_test_problems_tests__item7.jl")'\n-env JULIA_NUM_THREADS=1 JULIA_PKG_PRECOMPILE_AUTO=no timeout 3600 /home/crackauc/.juliaup/bin/julia +1 --startup-file=no --project=/home/crackauc/sandbox/tmp_20260708_121627_10236/.runic_env -e 'using Runic; exit(Runic.main(["--check", "."]))'\n-git diff --check