FIX: Image tiles crossing the dateline need special handling#2602
Draft
greglucas wants to merge 1 commit intoSciTools:mainfrom
Draft
FIX: Image tiles crossing the dateline need special handling#2602greglucas wants to merge 1 commit intoSciTools:mainfrom
greglucas wants to merge 1 commit intoSciTools:mainfrom
Conversation
When image tile requests crossing a dateline happen, there is a multipolygon that gets passed to the find images function. We don't necessarily want just the tiles that are within those geometries, but also the ones that could be between them.
greglucas
force-pushed
the
fix-add-image-multipolygon
branch
from
cc2c7dd to
12bf5b4
Compare
Contributor
Author
|
Thinking about this a bit more, this might expand the domain a little bit too much depending on the bounds of the polygons and turn two halves of an oval shape into a rectangle unnecessarily. I'll try and look into whether buffering the multipolygon is more appropriate here because I am now wondering if this has to do with the inexact boundary of Orthographic (or any curved boundaries). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When image tile requests crossing a dateline happen, there is a multipolygon extent that gets passed to the find images function. We don't necessarily want just the tiles that are within those geometries, but also the ones that could be between them.
closes #2579