moonlight-nightly: Add version 2573#1914
moonlight-nightly: Add version 2573#1914brian6932 wants to merge 2 commits intoScoopInstaller:masterfrom
Conversation
|
All changes look good. Wait for review from human collaborators. moonlight-nightly
|
```
Persisting Moonlight Game Streaming Project/Moonlight.ini
New-Item: ...\scoop\apps\scoop\current\lib\install.ps1:491
Line |
491 | … New-Item -Path $source -ItemType HardLink -Value $target …
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| The system cannot find the path specified.
```
| @@ -0,0 +1,53 @@ | |||
| { | |||
| "version": "2580", | |||
There was a problem hiding this comment.
After a year, the $buildNumber has only reached 2587.
I'm afraid it's not appropriate to use it directly as a version number for nightly build.
There was a problem hiding this comment.
You would have to make multiple requests in order to get the stable versioning, which isn't really applicable to this CI anyway, so it doesn't make a whole lot sense to do that Imo.
There was a problem hiding this comment.
You would have to make multiple requests in order to get the stable versioning,
Most nightly builds have this issue. How about simply adding a commit ID or a timestamp?
Or do you think we should merge or close this PR directly?
|
moonlight-qt now uses GitHub Actions for nightly builds instead of AppVeyor. Don't know whether this simplifies or complicates things, but AppVeyor had pretty low download cap and merging this PR as it is would have led to problems. |
3 participants
It's in extras
Relates to ScoopInstaller/Extras#13860