librehardwaremonitor(-dotnet10)-nightly: Add version 24963003480#2813
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR adds two new Scoop package manifests for LibreHardwareMonitor nightly builds. The manifests define download sources, checksums, installation/uninstallation hooks for config persistence, and automated version/update tracking via GitHub Actions workflows. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 47 minutes and 46 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (2)
bucket/librehardwaremonitor-nigthly.json (1)
3-3: Description doesn't communicate the nightly/pre-release nature.This is copied verbatim from the stable
extras/librehardwaremonitormanifest. Per the PR objectives, this package exists specifically to provide pre-release builds; users searchingscoop searchshould be able to tell this variant apart from stable at a glance. Consider appending a short qualifier such as " (nightly build from master)".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/librehardwaremonitor-nigthly.json` at line 3, The manifest's "description" field in bucket/librehardwaremonitor-nigthly.json currently duplicates the stable package text and doesn't indicate this is a nightly/pre-release; update the description string to append a short qualifier (for example: " (nightly build from master)" or similar) so users can distinguish librehardwaremonitor-nigthly from the stable extras/librehardwaremonitor in search results and listings.bucket/librehardwaremonitor-nigthly-dotnet10.json (1)
21-32: Identicalbinalias and shortcut as the base nightly manifest — co-install is impossible.Both this file and
bucket/librehardwaremonitor-nigthly.jsonexposeLibreHardwareMonitor.exeaslhmand create a shortcut named "Libre Hardware Monitor". Installing both will silently overwrite shims/shortcuts (thenotesfield is the only safeguard, and it's easy to miss). Differentiating the dotnet10 variant would let users keep both side-by-side and removes a class of foot-guns.♻️ Suggested differentiation
"bin": [ [ "LibreHardwareMonitor.exe", - "lhm" + "lhm-net10" ] ], "shortcuts": [ [ "LibreHardwareMonitor.exe", - "Libre Hardware Monitor" + "Libre Hardware Monitor (.NET 10)" ] ],🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/librehardwaremonitor-nigthly-dotnet10.json` around lines 21 - 32, The bin alias and shortcut in the dotnet10 manifest collide with the base nightly manifest (the "bin" entry mapping "LibreHardwareMonitor.exe" to "lhm" and the "shortcuts" entry "Libre Hardware Monitor"); update librehardwaremonitor-nigthly-dotnet10.json to use distinct identifiers (e.g., rename the shim "lhm" to "lhm-dotnet10" or "lhm-net10" and change the shortcut label to "Libre Hardware Monitor (dotnet10)" or similar) so co-installation won't overwrite shims/shortcuts; ensure the changed strings appear in the "bin" and "shortcuts" arrays and update any user-facing notes if present to match the new names.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/librehardwaremonitor-nigthly-dotnet10.json`:
- Around line 1-2: Fix the "nigthly" typo by renaming the bucket file and
package identifier from "librehardwaremonitor-nigthly-dotnet10" to
"librehardwaremonitor-nightly-dotnet10": rename the file (currently
bucket/librehardwaremonitor-nigthly-dotnet10.json), update any package/name
fields inside that JSON to use "nightly" instead of "nigthly", and update the PR
title and any related references (issue/metadata) to match the corrected
spelling; if the misspelling was intentional to match issue `#2812`, confirm with
a maintainer before merging.
- Line 5: Update the "notes" value to correctly warn about the conflicting
non-dotnet10 package: replace the self-referential and misspelled text with a
grammatically correct sentence such as "Do not install
librehardwaremonitor-nightly when installing
librehardwaremonitor-nightly-dotnet10, as they will override shims and shortcuts
for each other." Edit the "notes" field in the JSON (the "notes" key) to use the
correct package name "librehardwaremonitor-nightly" and correct grammar ("Do not
install" and "each other").
- Around line 42-53: Remove the redundant "&workflow=master" query parameter
from the checkver URL (the endpoint path /actions/workflows/master.yml/runs
already pins the workflow) and ensure the "checkver" object's "url" is updated
accordingly; keep the autoupdate block (the "autoupdate" -> "url" and "hash"
jsonpath) unchanged since the artifacts digest handling is correct.
In `@bucket/librehardwaremonitor-nigthly.json`:
- Line 5: Update the "notes" field to reference the correct conflicting package
name and fix the wording: replace the incorrect package reference with
"librehardwaremonitor-nigthly-dotnet10" (the actual package in this PR) and
rephrase the sentence to clear English, e.g. "Do not install
librehardwaremonitor and librehardwaremonitor-nigthly-dotnet10 together; they
will override each other's shims and shortcuts." Ensure this change targets the
"notes" property in bucket/librehardwaremonitor-nigthly.json.
---
Nitpick comments:
In `@bucket/librehardwaremonitor-nigthly-dotnet10.json`:
- Around line 21-32: The bin alias and shortcut in the dotnet10 manifest collide
with the base nightly manifest (the "bin" entry mapping
"LibreHardwareMonitor.exe" to "lhm" and the "shortcuts" entry "Libre Hardware
Monitor"); update librehardwaremonitor-nigthly-dotnet10.json to use distinct
identifiers (e.g., rename the shim "lhm" to "lhm-dotnet10" or "lhm-net10" and
change the shortcut label to "Libre Hardware Monitor (dotnet10)" or similar) so
co-installation won't overwrite shims/shortcuts; ensure the changed strings
appear in the "bin" and "shortcuts" arrays and update any user-facing notes if
present to match the new names.
In `@bucket/librehardwaremonitor-nigthly.json`:
- Line 3: The manifest's "description" field in
bucket/librehardwaremonitor-nigthly.json currently duplicates the stable package
text and doesn't indicate this is a nightly/pre-release; update the description
string to append a short qualifier (for example: " (nightly build from master)"
or similar) so users can distinguish librehardwaremonitor-nigthly from the
stable extras/librehardwaremonitor in search results and listings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3a5f65f8-eb41-4551-8358-c158a8e50978
📒 Files selected for processing (2)
bucket/librehardwaremonitor-nigthly-dotnet10.jsonbucket/librehardwaremonitor-nigthly.json
Co-authored-by: Copilot <copilot@github.com>
|
/verify |
|
All changes look good. Wait for review from human collaborators. librehardwaremonitor-nightly-dotnet10
librehardwaremonitor-nigthly
|
z-Fng
changed the title
z-Fng
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. librehardwaremonitor-dotnet10-nightly
librehardwaremonitor-nigthly
|
z-Fng
changed the title
2 participants
librehardwaremonitor-nigthlylibrehardwaremonitor-nigthly-dotnet10I drew heavily on the
prismlauncher-git.jsonmanifest, while trying to keep everything on GitHub APIs; unfortunately, the download link had to remainnightly.link(which is, in any case, one of the two links provided by the repository itself)The versions follow the run IDs of the
masterworkflow; otherwise, it would be impossible to have a URL that can be updated usingcheckverandautoupdateCloses #2812
(I've also already prepared a manifest for the Net10 version of the stable release, but I'm not sure whether to submit a pull request for this repo or for extras)
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit