Skip to content

Fix: use valve.open_valve/close_valve for valve entities #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkolo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: use valve.open_valve/close_valve for valve entities #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions custom_components/smart_thermostat/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,12 +976,17 @@ async def _async_heater_turn_on(self):
self.entity_id, ", ".join([entity for entity in self.heater_or_cooler_entity]))
return
for heater_or_cooler_entity in self.heater_or_cooler_entity:
data = {ATTR_ENTITY_ID: heater_or_cooler_entity}
if self._heater_polarity_invert:
service = SERVICE_TURN_OFF
if heater_or_cooler_entity.startswith('valve.'):
data = {ATTR_ENTITY_ID: heater_or_cooler_entity}
await self.hass.services.async_call(
VALVE_DOMAIN, 'open_valve', data)
else:
service = SERVICE_TURN_ON
await self.hass.services.async_call(HA_DOMAIN, service, data)
data = {ATTR_ENTITY_ID: heater_or_cooler_entity}
if self._heater_polarity_invert:
service = SERVICE_TURN_OFF
else:
service = SERVICE_TURN_ON
await self.hass.services.async_call(HA_DOMAIN, service, data)

async def _async_heater_turn_off(self, force=False):
"""Turn heater toggleable device off."""
Expand All @@ -1001,12 +1006,17 @@ async def _async_heater_turn_off(self, force=False):
if entity is None:
continue
for heater_or_cooler_entity in self.heater_or_cooler_entity:
data = {ATTR_ENTITY_ID: heater_or_cooler_entity}
if self._heater_polarity_invert:
service = SERVICE_TURN_ON
if heater_or_cooler_entity.startswith('valve.'):
data = {ATTR_ENTITY_ID: heater_or_cooler_entity}
await self.hass.services.async_call(
VALVE_DOMAIN, 'close_valve', data)
else:
service = SERVICE_TURN_OFF
await self.hass.services.async_call(HA_DOMAIN, service, data)
data = {ATTR_ENTITY_ID: heater_or_cooler_entity}
if self._heater_polarity_invert:
service = SERVICE_TURN_ON
else:
service = SERVICE_TURN_OFF
await self.hass.services.async_call(HA_DOMAIN, service, data)

async def _async_set_valve_value(self, value: float):
_LOGGER.info("%s: Change state of %s to %s", self.entity_id,
Expand Down