Conversation
|
The rest of Clippy errors are not mine. Out of scope, so no touching Also I want to change Skila schema to feature more advanced features, as it stands its too basic. |
| } | ||
| } | ||
|
|
||
| pub fn parse_column_default(default: Option<String>) -> Option<ColumnDefault> { |
There was a problem hiding this comment.
I understand this is intended to keep changes minimal. But this approach quite hacky and hard to maintain. It may be better to refactor ColumnQueryResult retrieval to follow recommended practices. We should also take generated columns into consideration.
There was a problem hiding this comment.
I agree with you.
I did it because MySQL parser used the same style:
https://github.com/sinder38/sea-schema/blob/41d89efde457aa5bc70c54609c96c5281c82affd/src/mysql/parser/column.rs#L265
Sqlite one just inlines it.
So if I am changing this it basically mandatory to change MySQL one.
I actually don't like how quite a lot of things are written is sea-*, but pushing for a refactor would require maintainer support and 100% would break the API.
Maybe someday
PR Info
Feat: safe to insertion of rows sea-orm#2975
New Features
Breaking Changes