Skip to content

release: 1.11.3#23

Merged
BCsabaEngine merged 1 commit into
mainfrom
fix/center
Oct 13, 2025
Merged

release: 1.11.3#23
BCsabaEngine merged 1 commit into
mainfrom
fix/center

Conversation

@BCsabaEngine

@BCsabaEngine BCsabaEngine commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Automatic leg collision detection during 3D mesh generation; overlapping legs are hidden to prevent geometry issues. Supports circular and rectangular components with no workflow changes.
  • Improvements

    • More reliable mesh generation. Hidden leg count is tracked and a warning is shown in the mesh preview when legs are filtered.
  • Documentation

    • Added “Smart Leg Placement” description to the README.
  • Chores

    • Release v1.11.3. Updated docs assets and service worker cache version for the new build.

@coderabbitai

coderabbitai Bot commented Oct 13, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

Adds automatic leg-component collision filtering to 3D mesh generation, introduces overlap detection helpers, and surfaces hidden leg counts via MeshInfoTuple and a modal notice. Updates type definitions, UI template logic, documentation (README/CLAUDE/CHANGELOG), version numbers, and docs assets/service worker versions.

Changes

Cohort / File(s) Summary
Mesh generation logic & types
src/lib/3d/mesh.ts, src/types/MeshInfo.ts
Added leg-component collision helpers; filter overlapping legs before mesh creation; extended MeshInfoTuple with hiddenLegsCount; applied filtered legs to main and hollow meshes.
UI modal notice
src/components/modal/ModalMeshDisplay.svelte
Conditional alert rendering when meshInfoTuple.hiddenLegsCount > 0; added await/branch to display hidden-legs warning.
Docs & guidance
README.md, CLAUDE.md, CHANGELOG.md
Documented “Smart Leg Placement,” collision detection behavior, new types, and release notes for v1.11.3.
Versioning & metadata
package.json
Bumped version to 1.11.3; updated @typescript-eslint packages from ^8.46.0 to ^8.46.1.
Service workers
public/service-worker.js, docs/service-worker.js
Updated VERSION to v1.11.3, affecting cache names; no logic changes.
Docs site assets
docs/index.html
Swapped built asset JS/CSS filenames; structure unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant M as ModalMeshDisplay
  participant G as generateMesh()
  participant H1 as isLegOverlappingCircle()
  participant H2 as isLegOverlappingRectangle()

  U->>M: Open Mesh Modal
  M->>G: Request mesh for project
  G->>G: Filter legs overlapping components
  loop For each leg vs circles
    G->>H1: check circle overlap
    H1-->>G: boolean
  end
  loop For each leg vs rectangles
    G->>H2: check rectangle overlap
    H2-->>G: boolean
  end
  G->>G: Build main/hollow meshes with filtered legs
  G-->>M: MeshInfoTuple { main, hollow, positive?, hiddenLegsCount }
  alt hiddenLegsCount > 0
    M-->>U: Show warning: some legs hidden
  else
    M-->>U: Render meshes
  end

  %% Styling notes
  note over G: New filtering step (v1.11.3)
  note over M: Conditional notice branch
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • release: 1.10.1 #20 — Earlier updates to mesh generation and positive mesh handling; this PR builds on that by adding leg-collision filtering and hiddenLegsCount.

Poem

In latticed fields where meshes grow,
I hop between the legs below—
“Mind the overlaps!” my whiskers warn,
Hidden feet are safely shorn.
With tidy nets and STL bright,
v1.11.3 takes flight—
A rabbit’s tweak for prints just right. 🐇✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/center

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b09e405 and 244ea1d.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (10)
  • CHANGELOG.md (1 hunks)
  • CLAUDE.md (2 hunks)
  • README.md (1 hunks)
  • docs/index.html (1 hunks)
  • docs/service-worker.js (1 hunks)
  • package.json (2 hunks)
  • public/service-worker.js (1 hunks)
  • src/components/modal/ModalMeshDisplay.svelte (1 hunks)
  • src/lib/3d/mesh.ts (5 hunks)
  • src/types/MeshInfo.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@BCsabaEngine BCsabaEngine merged commit 8d3dd09 into main Oct 13, 2025
1 check passed
@BCsabaEngine BCsabaEngine deleted the fix/center branch October 13, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant