Open
Conversation
github-actions
bot
added
the
👀 pr-needs-review
Extract all window and terminal logic from the monolithic main.cpp into a new TerminalWindow class. The refactored Terminal supports multiple tabs via GUI::TabWidget. Also fix LibVT::TerminalWidget to close the PTM file descriptor in its destructor, needed for correct cleanup when individual tabs are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tab support to the Terminal application. It also includes several commits that improve the
TabWidgetsystem across the application. Additionally, it adds an "Add Tab" button and implements automatic tab resizing when there is a width overflow. The Terminalmain.cppfile was one big main function so I refactored that completely into theTerminalWindowclass.Hope you like it :^)
Demo
terminal-tabs.mp4