Draft
Conversation
Single compile endpoint that analyzes a pipeline in an isolated session: - Loads statements via configureSession (tables then views) - DESCRIBE for exact mock schemas with watermark info - EXPLAIN for window function and temporal join detection - Computes needed views between mock boundaries and target - Returns compile plan with mock specs, session statements, query SQL No custom parsers, no regex patterns, no type inference. Uses Flink's own catalog, parser, and planner APIs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Strip *ROWTIME*, NOT NULL, and METADATA FROM annotations from type strings so they're usable in CAST expressions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Use SHOW TABLES / SHOW VIEWS catalog introspection for classification instead of fragile SQL text prefix matching - Fix extractObjectName to search for full CREATE patterns (CREATE TEMPORARY VIEW, CREATE TEMPORARY TABLE, etc.) to avoid false matches on TABLE keyword in query body - Clean type strings (remove *ROWTIME*, NOT NULL, METADATA) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- config_statements: SET, CREATE FUNCTION, USE (before mocks) - pipeline_statements: view DDL between mocks and target (after mocks) - Per-statement catalog diff for object classification (no extractObjectName) - Remove extractObjectName entirely Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix insideStringLiteral → insideStringOrComment: handle SQL doubled-
quote escaping (''), skip -- line comments and /* */ block comments
- sqlReferencesObject now skips matches in comments too
- Add bounds checking in describeMock for DESCRIBE result columns
- Add 23 unit tests for sqlReferencesObject, insideStringOrComment,
cleanType, and normalizeId
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation