Prevent macOS dock miniwindow preview from rendering blank#26
Merged
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Rust | Jun 1, 2026 12:22p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Copilot
AI
changed the title
[WIP] Fix window disappearing in dock on macOS
Prevent macOS dock miniwindow preview from rendering blank
May 30, 2026
kiyarose
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, the Dock preview (miniwindow image) could intermittently disappear after minimizing, while the app itself remained functional. Reopening and re-minimizing temporarily restored it, indicating unstable preview capture during miniaturization.
Root cause mitigation: deterministic miniwindow image
windowWillMiniaturize(_:)inAppDelegateto capture window content immediately before minimize.NSWindow.miniwindowImage, avoiding reliance on inconsistent implicit snapshotting.Supporting utility: view snapshot helper
NSView.snapshotImage()helper that:NSImagesuitable for Dock miniwindow usage.