-
-
Notifications
You must be signed in to change notification settings - Fork 37
Add Span<T> Sort extension Methods
#433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Span<T> Sort extension Methods
#433
Conversation
This reverts commit 8d0223a.
|
can u update from the main line |
Done. |
|
seems the build failed? |
Despite being on the latest changes from main, Rider says it can't resolve Test or Assert from TUnit and thinks there's missing NUnit references even though the project's switched to TUnit. I've tried rebuilding it with no change in errors. Every test class gives these errors:
|
|
@SimonCropp Should be fixed now. As an aside it would be nice to be able to use Ensure inside of Polyfill itself even if consuming projects don't enable it. Using it inside of Polyfill right now causes errors. |
|
Not sure why it's still failing on Appveyor but I'll keep looking into it. |
|
@SimonCropp Well now it's failing for an entirely different reason which started after most recently merging main into this branch. Consume can't find the extension method when it can sees the other Memory extension methods in Polyfill. Was there any Memory related configuration or packaging changes in main recently? |
|
@alastairlundy your changes look basically good. I am going to merge this, and trouble shoot the build on my side. |
Added missing
Span<T>Sort extension methods that are in .NET 5+ .Tests:
Consume:
Updated Span Methods:
Readme: