Skip to content

Adds ExprPlayerListOrder#8600

Merged
APickledWalrus merged 30 commits into
SkriptLang:dev/featurefrom
AnOwlBe:ExprPlayerListOrder
Jun 11, 2026
Merged

Adds ExprPlayerListOrder#8600
APickledWalrus merged 30 commits into
SkriptLang:dev/featurefrom
AnOwlBe:ExprPlayerListOrder

Conversation

@AnOwlBe

@AnOwlBe AnOwlBe commented Apr 28, 2026

Copy link
Copy Markdown

Problem

Its very useful as it grants ability for us to sort players on tab without need of teams.

Solution

Adds a ExprPlayerListOrder

with GET, SET & RESET for acceptChange (did not add DELETE as that would not make sense unless it did same thing as RESET)

Testing Completed

Tested on PaperMC 1.21.11 get, set, add, reset all work fine even with negative values

Supporting Information


Completes: none
Related: none
AI assistance: none

@AnOwlBe AnOwlBe requested a review from a team as a code owner April 28, 2026 02:59
@AnOwlBe AnOwlBe requested review from Pesekjak and TheMug06 and removed request for a team April 28, 2026 02:59
@skriptlang-automation skriptlang-automation Bot added needs reviews A PR that needs additional reviews needs triage An issue that hasn't been classified or verified yet labels Apr 28, 2026
@skriptlang-automation

This comment has been minimized.

@skriptlang-automation skriptlang-automation Bot added the feature Pull request adding a new feature. label Apr 28, 2026
@skriptlang-automation skriptlang-automation Bot removed the needs triage An issue that hasn't been classified or verified yet label Apr 28, 2026
@github-project-automation github-project-automation Bot moved this to In Review in 2.16 Releases Apr 28, 2026
@AnOwlBe AnOwlBe requested a review from sovdeeth April 28, 2026 03:40
@AnOwlBe

AnOwlBe commented Apr 28, 2026

Copy link
Copy Markdown
Author

oh I didn't see your additional comment after my reply yeah I think priority fits possibly weight?

@sovdeeth

Copy link
Copy Markdown
Member

Priority can probably stay, but you need a lot more explanation of this syntax in the description

@AnOwlBe

AnOwlBe commented Apr 28, 2026

Copy link
Copy Markdown
Author

Okay I made it more detailed

…nts/expressions/ExprPlayerListPriority.java

Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
@Efnilite Efnilite requested a review from Absolutionism April 28, 2026 19:47
@skriptlang-automation skriptlang-automation Bot removed the needs reviews A PR that needs additional reviews label Apr 28, 2026
…nts/expressions/ExprPlayerListPriority.java

Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

@ShaneBeee ShaneBeee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small nit picks. looks good otherwise :)

@skriptlang-automation skriptlang-automation Bot added the needs reviews A PR that needs additional reviews label Apr 29, 2026
@AnOwlBe AnOwlBe requested a review from APickledWalrus May 7, 2026 04:20
@AnOwlBe AnOwlBe requested review from Efnilite and sovdeeth May 12, 2026 01:52
AnOwlBe and others added 2 commits May 13, 2026 03:04
…nts/expressions/ExprPlayerListPriority.java

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@AnOwlBe

AnOwlBe commented May 25, 2026

Copy link
Copy Markdown
Author

curious as to why its failing on 1.21.11 I specifically tested on that version and stuff worked fine
image

@Efnilite

Copy link
Copy Markdown
Member

its failing in 26.1.1 too
image

@APickledWalrus APickledWalrus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things. Re-request for approval 🙂

AnOwlBe and others added 2 commits May 27, 2026 17:41
…nts/expressions/ExprPlayerListPriority.java

Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
…nts/expressions/ExprPlayerListPriority.java

Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
@AnOwlBe AnOwlBe requested a review from APickledWalrus May 27, 2026 21:42
@APickledWalrus APickledWalrus merged commit 0d1b9e7 into SkriptLang:dev/feature Jun 11, 2026
13 checks passed
@skriptlang-automation skriptlang-automation Bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jun 11, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Done - Awaiting Release in 2.16 Releases Jun 11, 2026
@skriptlang-automation skriptlang-automation Bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. feature Pull request adding a new feature.

Projects

Status: Done - Awaiting Release

Development

Successfully merging this pull request may close these issues.

7 participants