Extract common code from bow and crossbow

[lcy0x1]

• BowAmmoModifierHook: Change input parameter type from Player to LivingEntity

Restructure arrow shoot logic:

• User information (For player with bow: speed = 3, inaccuracy = 1, no infinity, do weapon durability cost)
• Shoot logic supporting multishot (common code)
  • Arrow creation logic. Use inheritance to allow crossbow to support rocket and mark arrow as shot from crossbow
  • Arrow modifier logic. Same for bow and crossbow.
  • Firing logic. This part bow differs from crossbow.
  • Shooting sound. Use inheritance to allow bow and crossbow to customize.
  • Durability cost. Same for bow and crossbow
• Individual code for weapon data manipulation

[lcy0x1]

This PR is the first step toward allowing mob to use TConstruct bows and arrows. They can call ModifiableLauncherWeapon.shootProjectiles to simulate shooting.

[KnightMiner]

I want to discuss this more; how is a non-player expected to remove the ammo from their inventory? Or are we just assuming they don't care about cleaning up empty stacks?

I know most mobs do infinite ammo, but imagine a dispenser like shooter.

[lcy0x1]

I would say the mob needs to be able to clean up empty stacks themselves. What harm will it do to not remove empty stacks? They are empty and isEmpty() returns true

[KnightMiner]

Mostly just memory waste, which is why vanilla typically does it.

[lcy0x1]

I don't think there is a realistic method to clear mob inventory, as each mob would have different implementations. Sounds like it doesn't matter that much.

Though if you think this part should be part of the API, then maybe LauncherUserInfo would be a place to add it.

[lcy0x1]

Any remaining items to discuss?

[KnightMiner]

I need to do a more in depth code review when I get a chance. I might have something after that.

[lcy0x1]

Thanks

[KnightMiner]

Apologizes, between the changes I pushed and the more recent update I spent most of the year on, this PR has gotten buried.

Is there anything notable missing from the living entity support for bows and crossbows?

I'm still not sure that firing the two should be sharing that much code since they work so differently.