Fix prefix and suffix, commands execution otimization.#15
Open
rube200 wants to merge 1 commit intoSmartlyDressedGames:masterfrom
rube200:Prefix_Suffix
Open
Fix prefix and suffix, commands execution otimization.#15rube200 wants to merge 1 commit intoSmartlyDressedGames:masterfrom rube200:Prefix_Suffix
rube200 wants to merge 1 commit intoSmartlyDressedGames:masterfrom
rube200:Prefix_Suffix
Conversation
Member
|
This sounds like a good change, especially fixing the usage of onCheckValid. Will examine further soon. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About permissions; It should do some checks before starting call functions that will not be used in some cases.
Example:
If the command does not exist, rocketmod should not call GetCooldown.
About prefixes and suffixes: i changed the event from
Provider.onCheckValidtoProvider.onCheckValidWithExplanationand some otimizations.btw rocketmod currently listen
Provider.onCheckValidWithExplanationsoProvider.onCheckValidis never called