Skip to content

Fix prefix and suffix, commands execution otimization.#15

Open
rube200 wants to merge 1 commit intoSmartlyDressedGames:masterfrom
rube200:Prefix_Suffix
Open

Fix prefix and suffix, commands execution otimization.#15
rube200 wants to merge 1 commit intoSmartlyDressedGames:masterfrom
rube200:Prefix_Suffix

Conversation

@rube200
Copy link
Copy Markdown

@rube200 rube200 commented May 15, 2020

About permissions; It should do some checks before starting call functions that will not be used in some cases.
Example:

IRocketCommand command = R.Commands.GetCommand(requestedCommand);
double cooldown = R.Commands.GetCooldown(player, command);

If the command does not exist, rocketmod should not call GetCooldown.

About prefixes and suffixes: i changed the event from Provider.onCheckValid to Provider.onCheckValidWithExplanation and some otimizations.

btw rocketmod currently listen Provider.onCheckValidWithExplanation so Provider.onCheckValid is never called

Copy link
Copy Markdown

@ennerperez ennerperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@SDGNelson
Copy link
Copy Markdown
Member

This sounds like a good change, especially fixing the usage of onCheckValid. Will examine further soon.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants