Skip to content

fix(rest): infinite retry loop on repeated 429 rate limit responses#651

Merged
Snazzah merged 1 commit intoSnazzah:masterfrom
fbrettnich:429-retries
Mar 11, 2026
Merged

fix(rest): infinite retry loop on repeated 429 rate limit responses#651
Snazzah merged 1 commit intoSnazzah:masterfrom
fbrettnich:429-retries

Conversation

@fbrettnich
Copy link
Copy Markdown
Contributor

Fixes #650

Changes

  • Added retryLimit check to the 429 handler in SequentialBucket#execute to throw a DiscordRESTError when the limit is reached
  • Incremented attempts counter on 429 retries so the retry limit is actually tracked

@fbrettnich fbrettnich requested a review from Snazzah as a code owner March 11, 2026 17:55
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 11, 2026

Open in StackBlitz

npm i https://pkg.pr.new/slash-create@651

commit: 0a56763

@Snazzah Snazzah added the type: bug Something isn't working label Mar 11, 2026
@Snazzah Snazzah merged commit ef4a481 into Snazzah:master Mar 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

429 retries bypass retryLimit, causing infinite retry loop

2 participants