Skip to content

fix(Sisyfos): 'mixerOnline' event was emitted continously #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nytamin merged 1 commit into from
Sep 9, 2025
Merged

fix(Sisyfos): 'mixerOnline' event was emitted continously #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions packages/timeline-state-resolver/src/integrations/sisyfos/connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const CONNECTIVITY_TIMEOUT = 1000 // ms
interface SisyfosApiEvents {
error: [Error]
initialized: []
mixerOnline: [boolean]
mixerOnlineChanged: []
connected: []
disconnected: []
}
Expand Down Expand Up @@ -238,10 +238,6 @@ export class SisyfosApi extends EventEmitter<SisyfosApiEvents> {
return this._mixerOnline
}

setMixerOnline(state: boolean) {
this._mixerOnline = state
}

private _monitorConnectivity() {
const pingSisyfos = () => {
if (this._oscClient) this._oscClient.send({ address: `/ping/${this._pingCounter}`, args: [] })
Expand Down Expand Up @@ -296,12 +292,20 @@ export class SisyfosApi extends EventEmitter<SisyfosApiEvents> {
this._clearPingTimer()
this.updateIsConnected(true)
this._pingCounter++
this.emit('mixerOnline', true)

if (!this._mixerOnline) {
this._mixerOnline = true
this.emit('mixerOnlineChanged')
}
} else if (message.args[0].value === 'offline') {
this._clearPingTimer()
this.updateIsConnected(true)
this._pingCounter++
this.emit('mixerOnline', false)

if (this._mixerOnline) {
this._mixerOnline = false
this.emit('mixerOnlineChanged')
}
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions packages/timeline-state-resolver/src/integrations/sisyfos/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ export class SisyfosMessageDevice extends DeviceWithState<SisyfosState, DeviceOp
this._sisyfos.on('disconnected', () => {
this._connectionChanged()
})
this._sisyfos.on('mixerOnline', (onlineStatus) => {
this._sisyfos.setMixerOnline(onlineStatus)
this._sisyfos.on('mixerOnlineChanged', () => {
this._connectionChanged()
})

Expand Down
Loading