Open
Conversation
leonardostsouza
changed the title
bamorim
suggested changes
Oct 1, 2019
bamorim
left a comment
bamorim
left a comment
There was a problem hiding this comment.
The spec is not as we discussed.
Also, the API is not set correctly (content-type wise).
Also, some of the responses are weird (returning 201 on a failed request is a completely no-no)
bamorim
suggested changes
Oct 2, 2019
bamorim
left a comment
bamorim
left a comment
There was a problem hiding this comment.
In general, it looks better. The only problem I think is the content type.
So adding the content type assertion to the tests is nice. Also, moving the utils and event store to a diferent file with corresponding unit tests (not passing through the API) would improve things.
Summing up
- Add assertions about content-type
- Move isValidSize and isBase64 to utils and add unit tests to them.
- Move event store related to something like event_store/in_memory.js and adding unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.