Refactor scheduling logic for strict clock alignment#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the integration's internal timer to resolve interval drift and align perfectly with PVOutput's strict interval expectations.
What Changed:
Replaced async_track_time_interval (which acts as a rolling countdown timer) with async_track_time_change (which acts as a strict Cron-style scheduler).
Added dynamic minute/hour generation based on the user's configured frequency setting.
Details
Previously, if Home Assistant restarted at 14:03, the 5-minute timer would fire at 14:08, 14:13, etc., causing data to drift out of sync with PVOutput's standard 5-minute buckets. By enforcing execution at exactly second=0 on the calculated minute marks (e.g., :00, :05, :10), uploads will now automatically resynchronize to the literal wall-clock time regardless of when Home Assistant reboots.
For Issue #1