DaysToEvent_TextOutput_vanilla.js#16
Open
bethwickerson wants to merge 2 commits intoSpark-AR-Community:masterfrom
Open
DaysToEvent_TextOutput_vanilla.js#16bethwickerson wants to merge 2 commits intoSpark-AR-Community:masterfrom
bethwickerson wants to merge 2 commits intoSpark-AR-Community:masterfrom
Conversation
…ber of days until an event that resets every year, and outputs to text
tomaspietravallo
approved these changes
Dec 7, 2021
Member
tomaspietravallo
left a comment
tomaspietravallo
left a comment
There was a problem hiding this comment.
Looks good to me! The comments are very clear and informative.
Re-reading DaysCountDownToEvent, both seem to have the same goal, but seeing different approaches can always be useful.
Will hold from single handedly merging these changes, but i’ll proceed if no other opinion is voiced before Monday
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a snippet to calculate the number of days until an event/festivity/holiday, and output to text. Resets every year!