Open
Conversation
…inline with markdown by introducing new templates
Owner
|
Seem you have some good improvements in there. Any chance you could split this into multiple distinct PRs that could be reviewed independently? |
Author
|
Thanks @Spenhouet! These were some hacky changes that were put in to get something working quickly. I can clean this up and separate it out if I get time + add tests. Alternatively if I don't come back to it soon, feel free to pick out anything that might be useful and I'll happily rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ual file name
Summary
Test Plan