Fix space export to include all pages#139
Open
AlexanderV wants to merge 4 commits intoSpenhouet:mainfrom
Open
Conversation
Owner
|
This was by design. We are using the Scroll Documents plugin to version spaces and the page versions are put alongside the homepage. We wouldn't want to download all versions all the time. I get that one might want to optionally do so. Maybe we need to have an explicit option for that? Something like "only_homepage_descendants", which is True by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spacesexport to include all pages in the space (not only homepage descendants)type=page AND space="KEY"with paginationWhy
Spaces can have top-level pages not under the homepage; previous logic missed them.
Testing