fix: handle non-list parent_tags in table converter#164
Open
saschabuehrle wants to merge 2 commits intoSpenhouet:mainfrom
Open
fix: handle non-list parent_tags in table converter#164saschabuehrle wants to merge 2 commits intoSpenhouet:mainfrom
saschabuehrle wants to merge 2 commits intoSpenhouet:mainfrom
Conversation
Owner
|
The change looks somewhat similar to https://github.com/Spenhouet/confluence-markdown-exporter/pull/153/changes |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116
markdownify can pass a non-list parent_tags value, which made the td membership check crash with TypeError. This guards the table-specific checks in convert_p, convert_ol, and convert_ul so non-list values fall back to default behavior.
Added a unit test that calls convert_p with parent_tags=False to cover the reported crash path.
Greetings, saschabuehrle