Fix of pets not continue fight after casting spell (All kill commands)#1493
Open
GladieUO wants to merge 4 commits intoSphereserver:devfrom
Open
Fix of pets not continue fight after casting spell (All kill commands)#1493GladieUO wants to merge 4 commits intoSphereserver:devfrom
GladieUO wants to merge 4 commits intoSphereserver:devfrom
Conversation
fix pets not sticking to target after casting spell
add check to not abuse player attacks
Contributor
|
I like this fix. Maybe there a better way to achieve it but it seem effective. I dont see what negative impact it could have. |
Contributor
Author
|
Well turns out the fix is not really a fix. If you turn warmode off, the pet / summon will go back to following. Its pissing me off. 😁😁 So its basically similar to all guard me now. |
better solution
Contributor
Author
|
I think I found much more elegant solution for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So there has been long time issue of pets that suppose to be casters, not continue fighting after spell gets off. They would immediately follow master.
Turns out whenever the master doesnt have memory OnHarmedBy(Enemy) + is not in war and "in fight with target", pets will just not stick to the target.
If player wanted his pets/summons to stick fighting and casting, he would have to call all guard me and attack target.
What it does?
After you call all kill and target your enemy
For sure there is better way how to fix this issue with pets falling back to follow master but I couldnt find it.