[BugFix] Fix memory leak in count aggregate function registration - #67490
Merged
stdpain merged 1 commit intoJan 8, 2026
Merged
Conversation
Count aggregate functions were registered without track_function() wrapper, causing memory leak detected by ASAN. All other aggregate functions in the resolver use track_function() for proper lifecycle management. Changes: - Wrap MakeCountAggregateFunction with track_function() - Wrap MakeCountNullableAggregateFunction with track_function()
Contributor
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
stdpain
approved these changes
Jan 7, 2026
Contributor
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[BE Incremental Coverage Report]✅ pass : 4 / 4 (100.00%) file detail
|
trueeyu
approved these changes
Jan 8, 2026
farhad-celo
pushed a commit
to farhad-celo/starrocks
that referenced
this pull request
Jan 20, 2026
…arRocks#67490) Signed-off-by: Farhad Shahmohammadi <f.shahmohammadi@celonis.com>
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Count aggregate functions were registered without track_function() wrapper, causing memory leak detected by ASAN. All other aggregate functions in the resolver use track_function() for proper lifecycle management.
Changes:
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Ensures
countaggregates are lifecycle-tracked to prevent memory leaks, consistent with other aggregates.aggregate_resolver_sumcount.cpp, wrapsMakeCountAggregateFunction<...>andMakeCountNullableAggregateFunction<...>withtrack_function()in_infos_mappingregistrations.Written by Cursor Bugbot for commit ddf8d6e. This will update automatically on new commits. Configure here.