[Refactor] Add ExecEnv guardrails and context scaffolding#71299
[Refactor] Add ExecEnv guardrails and context scaffolding#71299alvin-celerdata merged 2 commits intoStarRocks:mainfrom
Conversation
Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2948f8c4c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ExecEnv::ExecEnv() { | ||
| _refresh_service_contexts(); |
There was a problem hiding this comment.
Defer context refresh until members are initialized
Calling _refresh_service_contexts() in the default constructor copies member pointers into the service views before init() assigns them, but ExecEnv still has raw-pointer fields without in-class initialization (notably _lookup_dispatcher_mgr and _cache_mgr in exec_env.h). For non-static ExecEnv instances (including this test pattern), those fields are indeterminate, so this constructor path performs undefined reads and can propagate garbage pointers into runtime_services().
Useful? React with 👍 / 👎.
Signed-off-by: alvin-celerdata <alvin.zhao@celerdata.com>
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 78 / 78 (100.00%) file detail
|
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: