Add toggle to skip inserting "No speech detected" message#122
Open
lucyfarnik wants to merge 2 commits intoStarmel:masterfrom
Open
Add toggle to skip inserting "No speech detected" message#122lucyfarnik wants to merge 2 commits intoStarmel:masterfrom
lucyfarnik wants to merge 2 commits intoStarmel:masterfrom
Conversation
Add toggle to control whether the "No speech detected" message gets inserted into the active window. Prevents unwanted text from being pasted when the mic picks up silence or background noise.
Owner
|
I don’t want to see another simple toggle. It would be better to remove the text “No speech detected in the audio” from being pasted at all. Thank you. |
Remove the insertNoSpeechMessage preference toggle entirely and instead unconditionally skip pasting "No speech detected in the audio". This addresses reviewer feedback to never paste the no-speech text rather than giving users a toggle for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan