fix: stabilize guild monthly leaderboards#844
Open
ugcodrr wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ugcodrr
force-pushed
the
fix/guild-monthly-leaderboards
branch
from
302d5ab to
b408426
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Guild monthly GEXP was recomputed only from the current Hypixel member list. If a member left, or if current member history omitted a day that was previously cached, that contribution disappeared from the recomputed 30-day aggregate and Redis leaderboard scores could be updated downward without an actual monthly reset.
The member-level cached/current history merge also rebuilt the accumulator object on every cached day. Reusing the same helper used by the guild-level preserved totals keeps the stabilization behavior intact while reducing temporary allocations during guild refreshes.
Testing