Add steam-global-launch-options as submodule

[BlafKing]

Hi there! This is my first submission.
I've made a plugin that allows the user to configure any launch options that get automatically applied globally across all your Steam games.

Currently this plugin:

1. Gets the current original launch options for the game (if any)
2. Parses and merges them with your global options
3. Temporarily applies the combined options during launch
4. Restores original options after launch

Please let me know if anything requires adjustments/changing and I'll be more than happy to look into it!

[shdwmtr]

Hello! Thank you for the submission!

Millennium.callServerMethod is deprecated, use callable instead. You can find docs for it in the typedoc comment above the Millennium.callServerMethod function.

[BlafKing]

Thanks for the heads up!
I've made another commit where I've replaced the usage of callServerMethod with callable along with some minor logging changes! :)

Edit:
To add to this, I've also tested it on both Steam stable and Steam beta on both Windows and Linux! 👍🏻

[shdwmtr]

Code looks up to snuff, however I notice one issue.
Right now, you ship config.json along with the plugin, this means when your plugin gets updated, the users custom config.json will get overwritten with the auto generated one. The simplest way to address this would be just to check in python if the config file doesn't exist, and then just dump the default content into it.

Apart from that, Millennium is in a bit of a weird transition right now. We are in the process of changing Millennium's backend language from python to lua. I'm currently unsure whether I'll be adding any new python plugins until that point (it would be easier to manage). This also means at some point the backend of your plugin will need to be rewritten in lua. We have limited docs for that as of now though.

Lua plugin example
Some API docs

[BlafKing]

Good point indeed! Hadn't considered that. The plugin already creates a default config file if one doesn't exist, so I've simply removed the config.json from the repository to prevent any overwrites during updates.

Regarding the Python to Lua transition, I appreciate the heads up!
I'll definitely look into preparing a Lua version of the plugin so it's ready to switch over when the public version fully transitions from Python to Lua.

As for adding it now, that's totally up to you! No worries at all if you'd prefer to wait until after the transition is complete. I understand it's probably easier to manage things that way during this transitional period :)

[shdwmtr]

Hello! Just an update, lua support has been added and part of the stable Steam release. Checkout the plugin template, and the developer docs!

[BlafKing]

Hello! Just an update, lua support has been added and part of the stable Steam release. Checkout the plugin template, and the developer docs!

Awesome, thanks for letting me know!
I noticed that Millennium's in-steam config UI is now working, so I've opted to use that instead of a backend, let me know if there's anything I need to adjust further! Should be ready to merge if not :)

[shdwmtr]

Lmk if the test build has built your plugin correctly. On another note, you've accidentally added your repo to the gitmodules twice. Other than that, we can merge!

[BlafKing]

Lmk if the test build has built your plugin correctly. On another note, you've accidentally added your repo to the gitmodules twice. Other than that, we can merge!

Good catch! should no longer be a duplicate now.
The test build also seems to have built the plugin correctly! :)

[shdwmtr]

One thing I missed is the README. We don't allow download instructions that involve Millennium users installing third-party versions of the plugin (i.e versions built outside of Millennium's CI). The README should consist solely of instructions on how to install your plugin directly from Millennium, excluding custom releases that you've published!

[BlafKing]

All good! not really required anyway once it's available through Millennium :)
I've updated the README to only include instructions on how to install it directly from Millennium!