Skip to content

Mission support#49

Draft
kashish2210 wants to merge 9 commits intoStingraySoftware:mainfrom
kashish2210:missionSupport
Draft

Mission support#49
kashish2210 wants to merge 9 commits intoStingraySoftware:mainfrom
kashish2210:missionSupport

Conversation

@kashish2210
Copy link
Copy Markdown
Member

@kashish2210 kashish2210 commented Jun 2, 2025

I have added mission support. I have added one extra data field of Chandra for some metadata, but we can use axaf as the mission

Here I have tried a test case with verbose = true so that we can use each test separately, but I will move to this "test_suit" as keeping track with @fjebaker ;)

I have added more detailed synthetic data in the test suite
@matteobachetti, your review is required.

For a more detailed analysis with the fits data of different missions, manual test cases with a custom logging system, I consider visiting this notebook

NOTE: this is the sub-branch of #47 please review this commit leave rest

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 76.43505% with 78 lines in your changes missing coverage. Please review.

Project coverage is 88.22%. Comparing base (cddac34) to head (c1d4faa).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/lightcurve.jl 72.54% 42 Missing ⚠️
src/missionSupport.jl 58.18% 23 Missing ⚠️
src/events.jl 89.43% 13 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cddac34) and HEAD (c1d4faa). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (cddac34) HEAD (c1d4faa)
6 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   95.24%   88.22%   -7.03%     
==========================================
  Files           3        6       +3     
  Lines         505      849     +344     
==========================================
+ Hits          481      749     +268     
- Misses         24      100      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kashish2210 kashish2210 marked this pull request as draft June 15, 2025 11:36
Omiii-215 added a commit to Omiii-215/Stingray.jl that referenced this pull request Feb 27, 2026
This commit brings in the mission support features from PR 49 by kashish srivatsav while keeping the remaining codebase aligned with the upstream main branch. LightCurve dependencies were removed, and FITSMetadata constructors were updated.
Omiii-215 added a commit to Omiii-215/Stingray.jl that referenced this pull request Feb 27, 2026
This commit brings in the mission support features from PR 49 by kashish srivatsav while keeping the codebase aligned with upstream/main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants