Replaced three @resumable functions with native Julia iterators:#73
Replaced three @resumable functions with native Julia iterators:#73kashish2210 wants to merge 1 commit intoStingraySoftware:mainfrom
Conversation
Julia 1.12 changed macro argument handling, causing ResumableFunctions 0.6.10's @Resumable macro to fail with a MethodError (expecting LineNumberNode but receiving Method).
|
@matteobachetti and @fjebaker, I have made some updates in gti.jl and fourier.jl, as we had expected this resumable function failure earlier; now it is compatible with Julia {newer version}{1.12} |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 89.26% 88.81% -0.46%
==========================================
Files 5 5
Lines 1025 1091 +66
==========================================
+ Hits 915 969 +54
- Misses 110 122 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
You can see the test failure in #74 for the @Resumable function |
|
@kashish2210 can you add a test case with Julia 1.12, so that you can test that indeed it resolves the issue in #74? |
yeah it resolves the issue |
|
@matteobachetti, what happened exactly |
generate_indices_of_segment_boundaries_unbinnedandgenerate_indices_of_segment_boundaries_binnedingti.jlnow return zip and generator expressions instead of using @yieldget_flux_iterable_from_segmentsinfourier.jlnow returns a generator expression instead of using @Resumable with @yield