Skip to content

Replaced three @resumable functions with native Julia iterators:#73

Open
kashish2210 wants to merge 1 commit intoStingraySoftware:mainfrom
kashish2210:compatiblity-update
Open

Replaced three @resumable functions with native Julia iterators:#73
kashish2210 wants to merge 1 commit intoStingraySoftware:mainfrom
kashish2210:compatiblity-update

Conversation

@kashish2210
Copy link
Copy Markdown
Member

generate_indices_of_segment_boundaries_unbinned and generate_indices_of_segment_boundaries_binned in gti.jl now return zip and generator expressions instead of using @yield

get_flux_iterable_from_segments in fourier.jl now returns a generator expression instead of using @Resumable with @yield

Julia 1.12 changed macro argument handling, causing ResumableFunctions 0.6.10's @Resumable macro to fail with a MethodError (expecting LineNumberNode but receiving Method).
@kashish2210
Copy link
Copy Markdown
Member Author

@matteobachetti and @fjebaker, I have made some updates in gti.jl and fourier.jl, as we had expected this resumable function failure earlier; now it is compatible with Julia {newer version}{1.12}

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.81%. Comparing base (98935ce) to head (5b8b42a).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   89.26%   88.81%   -0.46%     
==========================================
  Files           5        5              
  Lines        1025     1091      +66     
==========================================
+ Hits          915      969      +54     
- Misses        110      122      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kashish2210
Copy link
Copy Markdown
Member Author

You can see the test failure in #74 for the @Resumable function

@matteobachetti
Copy link
Copy Markdown
Member

@kashish2210 can you add a test case with Julia 1.12, so that you can test that indeed it resolves the issue in #74?

@kashish2210
Copy link
Copy Markdown
Member Author

@kashish2210 can you add a test case with Julia 1.12, so that you can test that indeed it resolves the issue in #74?

yeah it resolves the issue

@kashish2210
Copy link
Copy Markdown
Member Author

@matteobachetti, what happened exactly @resumable macro broke in Julia 1.12 because Julia's internal compiler APIs changed. The package wasn't compatible with the newer Julia version, causing all tests to fail with MethodError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants