feat: split pdf into small chunks by pdfbox#5718
feat: split pdf into small chunks by pdfbox#5718intelliking wants to merge 3 commits intoStirling-Tools:mainfrom
Conversation
🌐 TOML Translation Verification Summary🔄 Reference Branch:
|
|
@Frooodle Please review my PR. Thanks. |
|
/deploypr |
|
Hi, @Frooodle Can you check my PR again? Thank you. |
|
@Frooodle Please review my PR. Thanks. |
1 similar comment
|
@Frooodle Please review my PR. Thanks. |
|
/deploypr |
🚀 PR Test DeploymentYour PR has been deployed for testing! 🔗 Test URL: http://23.22.230.180:5718 This deployment will be automatically cleaned up when the PR is closed. |
|
This is a very similar tool to split-pdf-by-sections. Would it make sense to combine the tools in the frontend so that the user can select if they want to split the file into multiple files or keep it as a single file? Can the same endpoint be used for both tools? |
|
@ConnorYoh Thanks for your review. As you mentioned these two tools are similar. The differences are multiple/single file option and unlike split-pdf-by-sections, new tool can split pages into regular paper size like A4 for print purpose. In my opinion, they shouldn't be combined. While they both divide pages, the user intent is different. In addition, the underlying PDF manipulation is different enough that combining them would require significant refactoring. |
|
@Frooodle @ConnorYoh Please review my PR. Thanks. |
|
/deploypr |
🚀 PR Test DeploymentYour PR has been deployed for testing! 🔗 Test URL: http://23.22.230.180:5718 This deployment will be automatically cleaned up when the PR is closed. |
Refactor: Replace mutool with PDFBox for Poster PDF Splitting
Summary
Refactored the "Split for Poster Print" feature to use Apache PDFBox instead of mutool, eliminating the external binary dependency while maintaining full functionality and improving code maintainability.
Changes
Improved from PR 5682
Backend Refactoring
PosterPdfControllerusing pure Java/PDFBox implementationProcessBuilderor shell command executionCloses #5644
Checklist
General
Testing (if applicable)