feat(viewer): handle keyboard shortcuts for print, save, undo, etc.#5748
feat(viewer): handle keyboard shortcuts for print, save, undo, etc.#5748balazs-szucs wants to merge 8 commits intoStirling-Tools:mainfrom
Conversation
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
|
/deploypr |
🚀 PR Test DeploymentYour PR has been deployed for testing! 🔗 Test URL: http://23.22.230.180:5748 This deployment will be automatically cleaned up when the PR is closed. |
|
Hi @balazs-szucs these are awesome! Also it runs reload unless I have clicked the pdf for rotate. It feels like there is some context logic going on that needs tightening up. These a great features! Improves the UX loads thanks |
Yes, it uses the same shortcuts as the browser, so if the site isn’t in focus, we can’t override the browser shortcut. Hence, the browser prints the website instead of our print command overriding it to print the PDF. I'm not quite certain what we can do about that, tbh. But I'll see what I can do. |
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
|
I was thinking about this for a while, realized it was actually my bad. Thanks for the review. Should be fixed |
|
/deploypr |
🚀 PR Test DeploymentYour PR has been deployed for testing! 🔗 Test URL: http://23.22.230.180:5748 This deployment will be automatically cleaned up when the PR is closed. |

Description of Changes
Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)