refactor(link-layer): migrate to EmbedPDF v2.6.2 annotation state for link rendering and improve link handling#5760
Merged
Frooodle merged 5 commits intoStirling-Tools:mainfrom Feb 23, 2026
Conversation
…endering and improve link handling Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
balazs-szucs
requested review from
ConnorYoh,
EthanHealy01,
Frooodle,
jbrunton96 and
reecebrowne
as code owners
dosubot
bot
added
the
size:L
stirlingbot
bot
added
Front End
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the PDF viewer link overlay to render/navigate/delete links using EmbedPDF’s annotation state (aligned with the v2.6.1 update), replacing the previous pdf-lib-based link extraction approach.
Changes:
- Update EmbedPDF packages from
2.6.0to2.6.1. - Refactor
LinkLayerto read link annotations fromuseAnnotation(documentId).stateand use annotation actions/destinations for navigation. - Simplify
LocalEmbedPDF’sLinkLayerusage by removing now-unneeded props (pdfUrl, page dimensions).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/core/components/viewer/LocalEmbedPDF.tsx | Updates LinkLayer invocation to match the new annotation-state-driven interface. |
| frontend/src/core/components/viewer/LinkLayer.tsx | Switches link extraction to EmbedPDF annotation state; updates navigation/deletion logic to use annotation targets/actions. |
| frontend/package.json | Bumps EmbedPDF dependencies to ^2.6.1. |
| frontend/package-lock.json | Locks EmbedPDF dependency tree to 2.6.1 artifacts. |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
/deploypr |
ConnorYoh
reviewed
Feb 20, 2026
Contributor
ConnorYoh
left a comment
ConnorYoh
left a comment
There was a problem hiding this comment.
Hi @balazs-szucs great work as always!
|
|
||
| interface LinkToolbarProps { | ||
| link: PdfLibLink; | ||
| ann: PdfLinkAnnoObject; |
Contributor
There was a problem hiding this comment.
I would prefer to still name link or annotationLink as that is its primary responsibility. I am also personally not a fan of abbreviating words. I have a terrible memory when reading through code :')
stirlingbot
bot
added
the
pr-deployed
reecebrowne
previously approved these changes
Feb 20, 2026
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
… link handling Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Collaborator
Author
|
/deploypr |
balazs-szucs
changed the title
ConnorYoh
approved these changes
Feb 23, 2026
stirlingbot
bot
removed
the
pr-deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)