Changed transformers_client design so it can support most (all?) HuggingFace models#208
Open
adjahossoualexandre wants to merge 36 commits intoSylphAI-Inc:mainfrom
Open
Conversation
Added 'tokenizer_kwargs' in TransformerLLMModelClient constructor for more flexibility. Added chat template argument in constructor for more flexibility. Added pad token check. Added tokenizer in '_infer_from_pipeline()' when chat_template is used (required). Fixed _handle_input() for 'apply_chat_template'==True. Not sure: ficed message in convert_inputs_to_api_kwargs().
Moved get_device andclean_device_cache at top of file. Allow user to specify autoclasses for Reranker models.
Member
|
@adjahossoualexandre Thank you for the effort, this is a big change, we will have to review a bit later! |
Author
Sure, let me know if you need me to explain some parts of the code! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New design
TransformerClient into 3 client classes:
Pros:
Cons: