Open
Conversation
…g to pyproject.toml- Update Makefile format commands to use config- Enhance pre-commit hooks with Ruff format- Removed circular dependencies- Standardize exclude patterns across tools- Fixed various redefinitions and commented out unused variables
…ncy, we should have one source-of-truth for formatting, which is the pre-commit
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fm1320
approved these changes
Dec 15, 2024
liyin2015
requested changes
Feb 10, 2025
Member
liyin2015
left a comment
There was a problem hiding this comment.
Please only keep the change of the pre-commit-config and other config files. The overall file changes we can run it later (too much conflicts to rebase)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #273
pre-commit-config.yaml,makefile, andpyproject.tomlto enforce proper pre-commit checks.pyproject.tomlmake formatBefore submitting
pytest output
Commit output