Merged
Conversation
Contributor
|
@lloydhamilton Hi, can you make sure tests pass locally too please, I will review |
Author
|
No probs, will get it fixed. I know what the issue is. Test passed locally on mine as I have a default AWS profile set up. Will mock those env vars. |
Author
|
hey @fm1320 I have updated the tests. Could you verify that the tests passed? |
Contributor
|
Hi @lloydhamilton , any more updates or is this ready? It generally looks good I just want to test a few more things when its complete |
Author
|
Hey @fm1320 no more updates on my end for this PR. Do let me know how the tests go. I should be available to address any changes. |
fm1320
approved these changes
Jan 20, 2025
phi-jkim
pushed a commit
that referenced
this pull request
Jul 22, 2025
feat/added bedrock streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added streaming functionality for Bedrock API integration. Followed as closely as possible the coding styles written in
openai_client.pyandollama_client.py..converse_streamendpoint when streaming is true.streaming = Trueisapi_kwargs.Since the
streamparameter is not a parameter recognised by Bedrock, I had to addapi_kwargs.pop("stream")when evaluatingapi_kwargsprior to bedrock API call.Related issue:
#283
Add tests that extends the tests written in #289
Before submitting