Fixes the Lazy Import for Qdrant#364
Open
Unobtainiumrock wants to merge 3 commits intoSylphAI-Inc:mainfrom
Open
Fixes the Lazy Import for Qdrant#364Unobtainiumrock wants to merge 3 commits intoSylphAI-Inc:mainfrom
Unobtainiumrock wants to merge 3 commits intoSylphAI-Inc:mainfrom
Conversation
Contributor
Author
|
Nevermind, I have to add back in duplicate packages in order for these github auto tests to pass. One moment. |
liyin2015
reviewed
Feb 14, 2025
Member
liyin2015
left a comment
liyin2015
left a comment
There was a problem hiding this comment.
can you not submit other files that are just format change.
liyin2015
reviewed
Feb 14, 2025
| OptionalPackages.QDRANT.value[0], OptionalPackages.QDRANT.value[1] | ||
| ) | ||
| from adalflow.core.embedder import Embedder | ||
| print(f"QDRANT MODULE: {qdrant_module}") |
liyin2015
reviewed
Feb 14, 2025
| ) | ||
| QDRANT = ( | ||
| "qdrant-client", | ||
| "qdrant_client", |
Member
There was a problem hiding this comment.
why this?, please change this back
liyin2015
reviewed
Feb 14, 2025
|
|
||
|
|
||
|
|
||
| [tool.poetry.group.test.dependencies] |
Member
There was a problem hiding this comment.
we have no pytest on project level, tests is ru under poetry in adalflow
remove this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details:
qdrant_module.http.models, whereas before it was underqdrant_module.models/adalflow/pyproject.toml. I resolved this by adding certain conditions on numpy and breaking out qdrant into its own group.because they already exist as optional deps above. If you need them
in test automatically, you'll install them with
poetry install --with test,<dep>.