Hackathon project8: Expose CUDA-managed STIR image queries in sirf.STIR#1380
Closed
Dimitra-Kyriakopoulou wants to merge 7 commits intoSyneRBI:masterfrom
Closed
Hackathon project8: Expose CUDA-managed STIR image queries in sirf.STIR#1380Dimitra-Kyriakopoulou wants to merge 7 commits intoSyneRBI:masterfrom
Dimitra-Kyriakopoulou wants to merge 7 commits intoSyneRBI:masterfrom
Conversation
Corrected a typo and improved clarity in the README.
Member
KrisThielemans
left a comment
There was a problem hiding this comment.
Initial impressions of this are good. More thorough review will follow later.
Author
|
Dear Professor @KrisThielemans,
|
Member
|
I think this should be closed, as all functionality is in #1381. If so, please close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is PART of Hackathon Project 8: update STIR data to CUDA managed pointers, then adapt sirf.STIR data-containers (images first) and expose the underlying CUDA managed pointer to Python. This PR is the SIRF part of that work. The companion STIR changes are available in the fork at Dimitra-Kyriakopoulou/STIR, branch Hackathon_Project08, and the runnable benchmark is in the repository Dimitra-Kyriakopoulou/ hackathon_project_08_stir_cuda_managed_pointers.
Changes in this pull request
NOTE: Project 8 requires more than a STIR internal fix: sirf.STIR also has to recognise the managed-memory-backed image and expose it at the Python layer.
Testing performed
NOTE: The runnable proof-of-use benchmark is kept separately in hackathon_project_08_stir_cuda_managed_pointers.
Related issues
Checklist before requesting a review
Contribution Notes
Please read and adhere to the contribution guidelines.
Please tick the following: