fix(feed): video duration calculated from Video component#1405
fix(feed): video duration calculated from Video component#1405sujal-into wants to merge 6 commits intomainfrom
Conversation
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WaDadidou
changed the title
| <Video | ||
| source={{ uri: web3ToWeb2URI(video.videoFile.url) }} | ||
| onPlaybackStatusUpdate={getVideoDuration} | ||
| videoStyle={{ | ||
| height: 0, | ||
| width: 0, | ||
| }} | ||
| /> |
There was a problem hiding this comment.
We must find another solution
There was a problem hiding this comment.
The best thing would be to store the duration at the post's creation. It's another PR that we have to pause before making some refactos
n0izn0iz
left a comment
n0izn0iz
left a comment
There was a problem hiding this comment.
still downloads all videos
There is two approach, I have taken.
If it is downloading video in first approach, we can implement the second one. If second one is also not working then we can ask user to manually enter the video duration like you said earlier in this issue. |
|
In the issue I said to do 2. |
Okay, so should i remove the approach one? In the second approach i did some refactoring. I also added new package MP4Box. Is the solution okay? |
@sujal-into , We need to refato. You can consider this issue as standed by |
3 participants
fix #1348