Fix extra preplay parameter when no ping is configured#71
Merged
MattiasBuelens merged 3 commits intomasterfrom Oct 8, 2025
Merged
Fix extra preplay parameter when no ping is configured#71MattiasBuelens merged 3 commits intomasterfrom
MattiasBuelens merged 3 commits intomasterfrom
Conversation
.../java/com/theoplayer/android/connector/uplynk/internal/UplynkSsaiDescriptionConverterTest.kt
Outdated
Show resolved
Hide resolved
MattiasBuelens
approved these changes
Oct 8, 2025
MattiasBuelens
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the player adds a
&ad.pingc=0to preplay parameters when there is no ping configuration, which causes a 403 since the requested preplay URL no longer matches the signature due to the extra&ad.pingc=0. This change aligns the behavior to the Web SDK implementation.There is also a small correction for the parameter name.