Skip to content

Do not start new session when player is paused #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvanlaerhoven merged 3 commits into from
Oct 23, 2025
Merged

Do not start new session when player is paused #72

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
beb8f5c
Do not start new session when player is paused
tvanlaerhoven Oct 13, 2025
45bf289
Report other player states as well
tvanlaerhoven Oct 20, 2025
9337338
Extract player state
tvanlaerhoven Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions ...onviva/src/main/java/com/theoplayer/android/connector/analytics/conviva/ConvivaHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import com.theoplayer.android.api.event.EventListener
import com.theoplayer.android.api.event.ads.AdEvent
import com.theoplayer.android.api.event.player.*
import com.theoplayer.android.api.player.Player
import com.theoplayer.android.api.player.ReadyState
import com.theoplayer.android.connector.analytics.conviva.ads.AdReporter
import com.theoplayer.android.connector.analytics.conviva.theolive.THEOliveReporter
import com.theoplayer.android.connector.analytics.conviva.utils.ErrorReportBuilder
Expand Down Expand Up @@ -224,17 +225,28 @@ class ConvivaHandler(
// End current session if one had already started
maybeReportPlaybackEnded()

// Start new session
maybeReportPlaybackRequested()
// If play-out was paused, the new session will start once play-out resumes.
if (!player.isPaused) {
// Start new session
maybeReportPlaybackRequested()
}

// Pass new metadata
setContentInfo(metadata)

// Notify current playback state
if (player.isPaused) {
reportPause()
} else {
reportPlaying()
// Report current playback state
convivaVideoAnalytics.reportPlaybackMetric(
ConvivaSdkConstants.PLAYBACK.PLAYER_STATE,
getPlayerState()
)
}

private fun getPlayerState(): ConvivaSdkConstants.PlayerState {
return when {
player.isEnded -> ConvivaSdkConstants.PlayerState.STOPPED
player.isPaused -> ConvivaSdkConstants.PlayerState.PAUSED
player.readyState >= ReadyState.HAVE_FUTURE_DATA -> ConvivaSdkConstants.PlayerState.PLAYING
else -> ConvivaSdkConstants.PlayerState.BUFFERING
}
}

Expand Down
Loading