Normal contributors should be able to unlink links they created themselves#3272
Draft
kumakyoo42 wants to merge 1 commit intoTatoeba:devfrom
Draft
Normal contributors should be able to unlink links they created themselves#3272kumakyoo42 wants to merge 1 commit intoTatoeba:devfrom
kumakyoo42 wants to merge 1 commit intoTatoeba:devfrom
Conversation
Author
|
I decided to stop contributing to Tatoebas codebase. Meanwhile I tried several times to add some tests, but I have to give up here too - I don't understand the code, I've got no idea where to start, and this is systematic, because it repeats over and over again. I'm sorry, but I can't continue. |
Member
|
Thank you for your valuable contributions, I can take over your opened PRs. It looks like you have been struggling a lot with Tatoeba’s code and I feel a bit sorry for that. Maybe this particular PR is a bit too hard, because it is highly tied to CakePHP, which I know is not your cup of tea. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses issue #3246.
This works now, but I still have to add some tests.