fix(mod/versioning): use fixed version for deps when possible#41
Open
parthpower wants to merge 1 commit intoTekunogosu:omegafrom
Open
fix(mod/versioning): use fixed version for deps when possible#41parthpower wants to merge 1 commit intoTekunogosu:omegafrom
parthpower wants to merge 1 commit intoTekunogosu:omegafrom
Conversation
should partially fix Tekunogosu#40 this technically breaks VS's mod dep definition which says "this version is minimum version required for mod" and not "version is semver version constraint" but it maybe better to use semver constraints for these deps anyways?
Owner
|
Heya, thanks for the PR. This doesn't actually fix the issue at hand. The problem lies in the fact that when a mod requires a specific version of a mod its suppose to "pin" that mod version, but its not happening that way. This is a known issue and is on my radar, I just have not had time to put into rustique as of late. I'll keep it open if you would like to try to fix it, but know that it will eventually be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should partially fix #40
this technically breaks VS's mod dep definition which says "this version is minimum version required for mod" and not "version is semver version constraint" but it maybe better to use semver constraints for these deps anyways?