Add test coverage for Raman simulation module#561
Open
LynchXLQ wants to merge 1 commit intoTelecominfraproject:masterfrom
Open
Add test coverage for Raman simulation module#561LynchXLQ wants to merge 1 commit intoTelecominfraproject:masterfrom
LynchXLQ wants to merge 1 commit intoTelecominfraproject:masterfrom
Conversation
LynchXLQ
force-pushed
the
test/raman-simulation-coverage
branch
3 times, most recently
from
53a785a to
99f4b9d
Compare
- Add 13 tests covering RamanFiber initialization, gain/loss profiles, spontaneous Raman scattering, stimulated Raman, pump propagation, signal-pump interaction, edge cases, and numerical stability - Add author entry to AUTHORS.rst
LynchXLQ
force-pushed
the
test/raman-simulation-coverage
branch
from
99f4b9d to
05e5319
Compare
Author
|
I've pushed the changes to GerritHub: https://review.gerrithub.io/c/Telecominfraproject/oopt-gnpy/+/1231191 Looking forward to your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive automated test coverage for the Raman simulation module, which was previously lacking automated tests.
Resolves #282
New Tests (13 total)
Attenuation Profile (no SRS) — 5 tests
exp(-alpha * L)rhofield equalssqrt(loss_profile)Stimulated Raman Scattering — 4 tests
End-to-End Fiber Propagation — 3 tests
Data Class — 1 test
StimulatedRamanScatteringconstruction and field verificationAll tests use a simple single-link topology with ~10 channels as suggested in the issue.
cc @jktjkt